[dev] Re: [cvs] commit: nag/lib Driver.php turba/lib Driver.php

[Jan Schneider]

Zitat von Chuck Hagenbuch <chuck at horde.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>>   Log:
>>   This won't work, session IDs are not numbers of base 10. Or was 
>> the intention to attach the session ID to the UID?
>
> This was taken from MIME::generateMessageID(), so if you're changing it here,
> change it there too.

Heh, the only place of the dozen where we generate those strings that used
session_id(). :-) Removed there to.

Maybe we should move this into a Util:: method?
Util::randomString(int $length)

> All we need is a reliably unique/mostly random value. Potentially 
> exposing the
> session id in it is probably a bad idea in any case.

If we need more entropy in MIME::generateMessageID() (or anywhere else for
that matter), we could use mt_rand() like in Util::createTempDir().

Jan.

--
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/