[dev] Reverse commit to FBView.php
Jason Rust
jrust at rustyparts.com
Tue Oct 5 14:04:38 PDT 2004
When this commit:
http://cvs.horde.org/diff.php/kronolith/lib/FBView.php?r1=1.5&r2=1.6&ty=u
was made it seems to have broken the freebusy view. Instead of showing each
user's f/b info it only shows the info for the last user in the list.
Assigning by reference seems to change reference to all the previous entries
in $_requiredMembers. Perhaps a PHP bug (I am running 4.3.8)? Exactly what
happens is:
1st call to addRequiredMember($userA) and $_requiredMembers now looks like
this (simplified):
array { 0 => array { user => "user A" } }
2nd call to addRequiredMember($userB) and it now looks like this:
array { 0 => array { user => "user B" }, 1 => array { user => "user B" } }
There doesn't seem to be any necessary reason for assigning the object by
reference and reversing the above patch fixes the problem.
-Jason
More information about the dev
mailing list