[dev] Re: Horde_Share patch

Chuck Hagenbuch chuck at horde.org
Mon Oct 25 19:48:23 PDT 2004


Quoting Ben Chavet <ben at chavet.net>:

> My last patch had a small logic error.  Please disregard that one and
> apply this one.  Thanks.

>> attached patch fixes the getShareCriteria function to honor the 
>> $owner parameter
>> properly.  Somebody might want to double-check my guest logic, but 
>> as far as I
>> can tell it should be secure.

$owner is a boolean, so the first part of your change wasn't correct, but
(except for substituting $owner for $userid) the second part looked good. I've
committed the modified version, thanks.

-chuck

-- 
"But she goes not abroad in search of monsters to destroy." - John 
Quincy Adams


More information about the dev mailing list