[dev] Turba browse.php patch

Chuck Hagenbuch chuck at horde.org
Wed Oct 27 12:43:49 PDT 2004


Quoting Michael Rubinsky <mike at theupstairsroom.com>:

> Unless I'm missing something, I don't see why we should  check
> $curSource['export']) in browse.php.  Doing it this way prevents an
> addressbook from being browsed if 'export' = false.  According to
> sources.php.dist the export variable is used to allow or disallow an
> addressbook from being exported to a .csv or other type of text file.
> Setting it to false currently stops it from being browsed as well.  This
> small patch fixes this...

Right, the name is bad, but the idea is that you probably don't want to let
people browse an addressbook for the same reason you don't want them to export
its entire contents - it's huge. We should probably just have two different
settings for this.

-chuck

-- 
"But she goes not abroad in search of monsters to destroy." - John 
Quincy Adams


More information about the dev mailing list