[dev] Re: PGP in IMP Options gone?

[Chuck Hagenbuch]

Quoting Sander Dalemans <sander at gamerszone.nl>:

> I did some backtracing in the PHP files and i think it goes wrong in the
> Prefs/UI.php file of the framework, groupIsEditable to be exactly. On
> line 40 of this file it is checking if the key 'url' in the array $group
> is set. But $group is not an array, it is just a string with the group
> name itself. So all preference blocks with an url set and without
> 'members' will fail in this test.
>
> I have created this little patch, it will now check the url key on the
> $prefGroups array. This works for me, and i do not see any reasons why
> it should not for others.

Indeed, it looks good. I've committed it - thanks.

> But this raises the question why you where unable to reproduce this? As
> far as i can see it is impossible to get the pgp etc. blocks with the
> default prefs.php in imp and this code?

Yeah. I don't know, and since your fix works for you, works for me, and looks
much more correct than the existing code, I'm just going to go with it. :)

-chuck

-- 
"But she goes not abroad in search of monsters to destroy." - John 
Quincy Adams