[dev] trean patch

Chuck Hagenbuch chuck at horde.org
Fri Dec 3 13:59:07 PST 2004


Quoting Ben Chavet <ben at chavet.net>:

> I don't know if anybody else noticed this, but I could only store about 8
> bookmarks per category because my postgres "text" field would fill up.
>
> The attached patch takes care of this by making better use of the datatree
> structure.  It stores the bookmark information in the 
> horde_datatree_attributes
> table instead of the horde_datatree datatree_data text field.  I simply added
> _toAttributes() and _fromAttributes() functions.

You weren't handling attributes *other* than bookmarks in 
_toAttributes(), which
could be a problem later down the road. Otherwise looked good. It's 
committed...

> I don't have a conversion script for existing bookmarks. And to be honest, it
> could be weeks before I find this kind of time again to write one (I love my
> job, but it keeps me very busy).  Maybe somebody else could step up 
> on that for me?

... as is the conversion script I came up with and tested. Thanks!

-chuck

-- 
"But she goes not abroad in search of monsters to destroy." - John 
Quincy Adams


More information about the dev mailing list