[dev] Re: vmailmgr.inc updated

[Max Kalika]

[Please send these requests to the list]

Your patch is incorrect.  It ignores the $username parameter to the
function and bypasses any configured hooks.  The proper way to do this, is
to enable 'default_username' hook in the configuration.  If you don't
provide a _passwd_hook_default_username() function, you'll get the
Auth::getAuth() result by default.

Quoting "Bat[e]" <bate at bate.de>:

> Hi,
> 
> today i updated to horde 3.x and updated too the sork stuff. So please
> patch it to the repository. I fixed a problem with the new username.
> VmailMgr required the complete login name (ie. bate at php.net) and not just
> the name (ie. bate).
> 
> cvs diff: Diffing lib
> cvs diff: Diffing lib/Driver
> Index: lib/Driver/vmailmgr.php
> ===================================================================
> RCS file: /repository/passwd/lib/Driver/vmailmgr.php,v
> retrieving revision 1.10
> diff -u -r1.10 vmailmgr.php
> --- lib/Driver/vmailmgr.php     6 Apr 2004 00:11:33 -0000       1.10
> +++ lib/Driver/vmailmgr.php     19 Dec 2004 19:34:15 -0000
> @@ -26,7 +26,7 @@
>              return PEAR::raiseError('vmail.inc not found ! (' .
> $this->_params['vmailinc'] . ')');
>          }
> 
> -        $_splitted = split('@', $username);
> +        $_splitted = split('@', Auth::getAuth());
>          $_username = $_splitted[0];
>          $_domain = $_splitted[1];
>          $_returnChange = vchpass($_domain, $old_password, $_username,
> $new_password);
> 
> --
> Marco Kaiser / bate at php.net

-- 
--mk