[dev] Re: [cvs] commit: framework/Browser Browser.php framework/Util Array.php String.php Util.php

[Jan Schneider]

Zitat von Chuck Hagenbuch <chuck at horde.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>>> Only that it makes it harder to tell what dependancies the class 
>>> (as a whole)
>>> has. I was looking over some code for use outside of Horde proper, 
>>> and this is what made sense to me as tweaks.
>>
>> But that would render "optional" requirements in package.xml useless. And
>> that's actually the place where dependencies should be defined. Beside the
>> place (method) where dependent classes are used of course.
>
> Yup, you're entirely right. So that would mean moving the Array.php 
> include in
> Browser.php and the Browser.php include in Util.php, right?
>
> If we're on the same page on that, let me know, and I'll make those
> changes/fixes.

I don't know off my head in which *classes* the other files are actually
used, the point is that the other files should only be loaded in the
*methods* where they are used.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/