Fwd: Re: [dev] [patch] Correct Thread visualization

Jan Schneider jan at horde.org
Wed Jan 26 03:51:23 PST 2005



----- Weitergeleitete Nachricht von kteam.eu at gmail.com -----
     Datum: Wed, 26 Jan 2005 12:08:22 +0100
       Von: k-team k-team <kteam.eu at gmail.com>
Antwort an: k-team k-team <kteam.eu at gmail.com>
   Betreff: Re: [dev] [patch] Correct Thread visualization
        An: Jan Schneider <jan at horde.org>

when you delete a message the resulting array containing thread
structure is missing the matching index, and this is correct. but when
you try to get the thread list iterating $key it breaks and you get an
incomplete list. The right behaviour is to continue with next step.

         $thread_list = array($this->_thread[$key]['index']);
         while ($key++) {
             if (!isset($this->_thread[$key])) {
                  break;     <--------------


On Wed, 26 Jan 2005 11:20:05 +0100, Jan Schneider <jan at horde.org> wrote:
> Zitat von k-team k-team <kteam.eu at gmail.com>:
>
> > When deleted messages are present in the thread the behaviour isn't
> > correct because the visualization is interrupted.
>
> Can you explain what exactly this should fix? Threading works fine for me
> with deleted messages.
>
> Jan.
>
> --
> Do you need professional PHP or Horde consulting?
> http://horde.org/consulting/
>
> --
> Horde developers mailing list - Join the hunt: http://horde.org/bounties/
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: dev-unsubscribe at lists.horde.org
>



----- Ende der weitergeleiteten Nachricht -----


Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/


More information about the dev mailing list