[dev] Fwd: [patch] imp api; </option> tags

[Ben Chavet]

This message is in MIME format.

--=_1b28b1nzgco0
Content-Type: text/plain;
	charset=UTF-8;
	format="flowed"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit





----- Forwarded message from js at camaya.net -----
    Date: Mon, 14 Feb 2005 21:03:56 +0000
    From: Jakob Schroeter <js at camaya.net>
Reply-To: Jakob Schroeter <js at camaya.net>
Subject: Fwd: [patch] imp api; </option> tags
      To: Ben Chavet <ben at horde.org>

Hi,

since I can't post to the dev list I send this directly to you.
Attached are two mini patches, one descrambling the password in the imp api,
the other correctly closing the </option>-tags in Tree_select.

cheers,
Jakob


----- End forwarded message -----


--=_1b28b1nzgco0
Content-Type: multipart/mixed;
	boundary="Boundary-01=_8IRECdoH9pBvAeQ"
Content-Transfer-Encoding: 7bit

Content-Type: multipart/mixed;
  boundary="Boundary-01=_8IRECdoH9pBvAeQ"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--Boundary-01=_8IRECdoH9pBvAeQ
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


Hi,

since I can't post to the dev list I send this directly to you.
Attached are two mini patches, one descrambling the password in the imp api,
the other correctly closing the </option>-tags in Tree_select.

cheers,
Jakob

--Boundary-01=_8IRECdoH9pBvAeQ
Content-Disposition: attachment;
	filename="imp_api.diff"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

A non-text attachment was scrubbed...
Name: imp_api.diff
Type: text/x-diff
Size: 709 bytes
Desc: not available
Url : http://lists.horde.org/archives/dev/attachments/20050214/033d7408/imp_api.bin

--Boundary-01=_8IRECdoH9pBvAeQ
Content-Disposition: attachment;
	filename="tree_select.diff"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

A non-text attachment was scrubbed...
Name: tree_select.diff
Type: text/x-diff
Size: 792 bytes
Desc: not available
Url : http://lists.horde.org/archives/dev/attachments/20050214/033d7408/tree_select.bin

--Boundary-01=_8IRECdoH9pBvAeQ--

--Boundary-01=_8IRECdoH9pBvAeQ
Content-Type: text/plain;
	charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Hi,

since I can't post to the dev list I send this directly to you.
Attached are two mini patches, one descrambling the password in the imp api,
the other correctly closing the </option>-tags in Tree_select.

cheers,
Jakob

--Boundary-01=_8IRECdoH9pBvAeQ
Content-Type: text/x-diff;
	charset=us-ascii;
	name="imp_api.diff"
Content-Disposition: attachment;
	filename="imp_api.diff"
Content-Transfer-Encoding: 7bit

Index: imp/lib/api.php
===================================================================
RCS file: /repository/imp/lib/api.php,v
retrieving revision 1.98
diff -u -3 -p -B -r1.98 api.php
--- imp/lib/api.php     4 Feb 2005 10:21:37 -0000       1.98
+++ imp/lib/api.php     14 Feb 2005 20:51:08 -0000
@@ -262,7 +262,7 @@ function _imp_userList()
 {
     $params = $_SESSION['imp']['admin']['params'];
     $params['admin_user'] = $params['login'];
-    $params['admin_password'] = $params['password'];
+    $params['admin_password'] = Secret::read(Secret::getKey('imp'), $params['password']);
     require_once 'Horde/IMAP/Admin.php';
     $imap = &new IMAP_Admin($params);
     return $imap->listMailboxes();
--Boundary-01=_8IRECdoH9pBvAeQ
Content-Type: text/x-diff;
	charset=us-ascii;
	name="tree_select.diff"
Content-Disposition: attachment;
	filename="tree_select.diff"
Content-Transfer-Encoding: 7bit

Index: framework/Tree/Tree/select.php
===================================================================
RCS file: /repository/framework/Tree/Tree/select.php,v
retrieving revision 1.1
diff -u -3 -p -B -r1.1 select.php
--- framework/Tree/Tree/select.php      25 Jan 2005 17:38:13 -0000      1.1
+++ framework/Tree/Tree/select.php      14 Feb 2005 20:55:27 -0000
@@ -116,7 +116,7 @@ class Horde_Tree_select extends Horde_Tr

         $output = '<option value="' . $node_id . '"' . $selected . '>';
         $output .= str_repeat('&nbsp;&nbsp;', $this->_nodes[$node_id]['indent']) . $this->_nodes[$node_id]['label'];
-        $output .= '</option';
+        $output .= '</option>';

         if (isset($this->_nodes[$node_id]['children']) &&
             $this->_nodes[$node_id]['expanded']) {
--Boundary-01=_8IRECdoH9pBvAeQ--

--=_1b28b1nzgco0
Content-Disposition: inline
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.horde.org/archives/dev/attachments/20050214/033d7408/attachment.bin

--=_1b28b1nzgco0--