[dev] Re: merk edit item - DUCK, READ THIS!
Chuck Hagenbuch
chuck at horde.org
Tue Apr 5 07:25:33 PDT 2005
Quoting Duck <duck at obala.net>:
> html cleanup
Okay, all of these have been committed. PLEASE, PLEASE, for future patches:
1. Read docs/CODING_STANDARDS. You're missing spaces in places like
array('foo' => 'bar') - note the space on either side of the =>. Same
for commas seperating argument lists, etc.
2. Use cvs diff to generate the patches so that they're not
absolute-pathed to your own install and can be applied more easily.
3. Consolidate related diffs into single patches (again using cvs diff
- cvs diff -urN) so there's a single patch to apply instead of one per
file touched.
Thanks,
-chuck
--
"But she goes not abroad in search of monsters to destroy." - John
Quincy Adams
More information about the dev
mailing list