[dev] extra arg in Cipher_blowfish::encryptBlock?

Jan Schneider jan at horde.org
Fri May 6 01:07:31 PDT 2005


Zitat von Matt Selsky <selsky at columbia.edu>:

> Here's the function declaration for encryptBlock() in Cipher_blowfish:
>
>    function encryptBlock($block, $key = null, $allparts = false)
>    {
>    ...
>    }
>
>
> $allparts is never referenced.  Any reason not to remove it?

I don't see any. While you're at it, you can also remove the empty ctors.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/



More information about the dev mailing list