[dev] [cvs] commit: framework/MIME/MIME Contents.php

[Jan Schneider]

Zitat von Michael M Slusarz <slusarz at bigworm.curecanti.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>> jan         2005-09-15 09:34:47 PDT
>>
>>  Modified files:        (Branch: FRAMEWORK_3)
>>    MIME/MIME            Contents.php
>>  Log:
>>  Reference fixes. Is it by intention that getPart() doesn't return a
>> preference?
>>
>>  Revision    Changes    Path
>>  1.129.4.19  +3 -2      framework/MIME/MIME/Contents.php
>
> Possibly because we often times want to manipulate the MIME_Part
> without affecting the original message.  It's quite possible a better
> practice would be to have getPart() return a reference and have the
> calling code use cloneObject() if it is going to alter that object.

This would even be necessary to make it work as expected with PHP 5.

> However, changing this now is sure to break BC all over the place.

Yeah, that's why I didn't even try to change it. ;-)

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/