[dev] Attachments broken?

[Michael M Slusarz]

Quoting Marc Jauvin <marc at r4l.com>:

> Jan Schneider <jan at horde.org> wrote:
>
>> Zitat von Michael M Slusarz <slusarz at bigworm.curecanti.org>:
>>
>>> Quoting Marc Jauvin <marc at r4l.com>:
>>>
>>>> OK, I can see from the CVS log that this has been changed on purpous...
>>>> this is fine, except for one thing: if you don't have read permission
>>>> on the file you  upload or if the file does not actually exists, you
>>>> won't notice and the mail will be sent anyway (without warning).
>>>>
>>>> So if we're gonna keep this, we'd need some form of verification BEFORE
>>>> it's too late and the email gets delivered.
>>>
>>> Try what I just committed.
>>
>> The attach button shouldn't go completely. You can't set a description
>> anymore now, or change the disposition, or preview the attachment after
>> attaching it anymore, which I personally used a lot to verify that I'm
>> really sending the correct file.
>
> Same thing here. I agree, we should keep the button (or have a
> javascript event that sends the "attach" action when focusing out of
> the text field)

Actually, you can.  Just hit refresh when done.  it will upload all 
files just like 'Attach' used to do.

but i realize that it is not as intuitive as it needs to be.  Maybe we 
bring back the attach button, remove the refresh button, and simply 
rename the Attach button "Update" or something similar and it will do 
both jobs that the attach button and refresh buttons used to do.

michael

_______________________________________
Michael Slusarz [slusarz at curecanti.org]