[dev] [cvs] commit: horde/lib/Block weatherdotcom.php

[Jan Schneider]

Zitat von "Kevin M. Myer" <kevin_myer at iu13.org>:

> Quoting Chuck Hagenbuch <chuck at horde.org>:
>
>> Quoting "Kevin M. Myer" <kevin_myer at iu13.org>:
>>
>>> I added XML_Serializer as a check in test.php (bug #2805), for the same
>>> reason the previous submitted had with adding the Cache check -
>>> spending two days trying to figure out why weather didn't work.  Should
>>> that check in test.php actually be moved to the weatherdotcom block?
>>
>> Sure, why not?
>>
>> -chuck
>
> I guess my question would be where should the checks for prerequisites
> go?  In test.php or in the weatherdotcom.php block file, or in both?
> In other words, is test.php supposed to be an exhaustive, all inclusive
> feedback mechanism for what's installed (or not), or should it only
> handle the base modules, and leave the blocks and other code fragments
> to check for their prerequisites?

Blocks should usually be encapsulated as much as possible, OTOH we tell 
all people to check test.php, so it should involve checks for all 
components distributed with Horde. Maybe with the exception of some 
obscure prerequisites like the SQL2XML package in the Serializer 
library.

I guess the answer is: in both.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/