[dev] Attachments Error Handling...

[Marc Jauvin]

Michael M Slusarz <slusarz at mail.curecanti.org> wrote:

> Quoting Marc Jauvin <marc at r4l.com>:
>
>> I tried the following using latest CVS HEAD code:
>>
>>  - attach a non-existent file
>>  - attach a file which I don't have read permission
>>
>> In both case, horde "thinks" everything worked well, creates the
>> attachment (size=0), and gives NO error notification.
>
> I'm confused, simply because IMP did not produce an error message in
> these cases previously.  As far as PHP can tell, the upload was
> successful - the filename is correct, and the filename simply has 0
> size.
>
> the only thing we could do is to ignore 0 size uploads, but i'm not
> sure if there is a drawback to this -- i.e. is it desirable for some
> reason to allow 0 byte attachments?

Personally, I would refuse 0 size uploads and produce a warning (like: 
file not found, or no permission to access the file).


>> I also tried to attach a file bigger than the max allowed size, and got
>> a server error... not sure about this one.
>
> if you are getting a webserver error, you need to check your webserver
> logs.  this is most likely not an IMP problem.

I'll do more testing for this.

-- 
Marc Jauvin
http://register4less.com
514-905-6500