[dev] [cvs] commit: imp message.php imp/lib/MIME Headers.php

[Eric Jon Rostetter]

Quoting Michael M Slusarz <slusarz at bigworm.curecanti.org>:

See below.

> Quoting Eric Jon Rostetter <eric.rostetter at physics.utexas.edu>:
>
>> Quoting Jan Schneider <jan at horde.org>:
>>
>> My changes to this seem to have worked.  You might want to try them.
>> They are fairly simple and seem to me to work.  Unless you know something
>> that is broken that I haven't noticed yet?
>>
>>> jan         2006-02-02 02:51:26 PST
>>>
>>>   Modified files:        (Branch: FRAMEWORK_3)
>>>     .                    message.php
>>>     lib/MIME             Headers.php
>>>   Log:
>>>   Revert
>>>
>>>   Revision    Changes    Path
>>>   1.92.2.19   +1 -19     imp/lib/MIME/Headers.php
>>>   2.560.4.29  +2 -2      imp/message.php
>
> Eric, can you send me a diff of your local changes so I can take a
> look?  I don't want to have to heavily debug this if you have already
> figured out a solution.
>
> michael

The change is to include all your changes as you made them, with one  
exception.
Leave the old getOB() in place, and use it everywhere except in
buildAddressLinks().  In that one routine, we use your new getOb() function
(in my case renamed as a local "myGetOb()" to avoid the override/conflict
between them).

Not sure why this works, how it works, but it seems to work.  Not seen
one like of trouble and I've been running this code for about 11 days now...

My diff is attached.

-- 
Eric Rostetter
The Department of Physics
The University of Texas at Austin

Go Longhorns!
-------------- next part --------------
Index: Headers.php
===================================================================
RCS file: /repository/imp/lib/MIME/Headers.php,v
retrieving revision 1.92.2.19
diff -r1.92.2.19 Headers.php
158c158
<         $array = $this->getOb($field);
---
>         $array = $this->myGetOb($field);
260a261,279
>     /**
>      * Get a header from the header object.
>      *
>      * @todo Move to framework for Horde 4.0.
>      *
>      * @param string $field  The header to return as an object.
>      *
>      * @return mixed  The field requested.
>      */
> 
>     function myGetOb($field)
>     {
>         if (!isset($this->_obCache[$field])) {
>             $value = $this->getValue($field);
>             $this->_obCache[$field] = IMP::parseAddressList($value);
>         }
>         return $this->_obCache[$field];
>     }
>