[dev] [cvs] commit: imp/docs CHANGES imp/lib base.php framework/MIME/MIME Structure.php imp/config conf.xml

[Michael M Slusarz]

Quoting Jan Schneider <jan at horde.org>:

> Zitat von Michael M Slusarz <slusarz at horde.org>:
>
>> Quoting Jan Schneider <jan at horde.org>:
>>
>>> Zitat von Michael M Slusarz <slusarz at horde.org>:
>>>
>>>> slusarz     2006-03-20 23:55:37 PST
>>>>
>>>>   Modified files:
>>>>     docs                 CHANGES
>>>>     lib                  base.php
>>>>     MIME/MIME            Structure.php
>>>>     config               conf.xml
>>>>   Log:
>>>>   Bug: 2702
>>>>   Allow admin to specify local default character set to use for
>>>> broken messages
>>>>   without charset information.
>>>
>>> This has to be a preference like in any other email client.
>>
>> I debated putting this in the preferences, but this is really not
>> something an end-user should normally be dealing with.  This is why
>> there are several sentences of explanations on what this is good for
>> in the config file - this would not transfer over as well to the
>> preferences (sure we could put it in a help entry, but we all honestly
>> know how few people read a help entry). In fact, this setting will
>> probably break more messages than it enables to be shown "correctly".
>
> I don't agree. You give the most important reason against this
> yourself below. People using the same Horde don't have to use the same
> preferred language/charset. I'm curious why you think this will break
> messages. AFAICS only messages that we currently handle as ascii
> message because they don't provide any charset are affected. If they
> are really ascii messages, nothing happens. If they are not in the
> users' preferred charset, the worst that could happen is that they
> still can't read it.

You've convinced me, not to mention that you are the charset expert so  
if you are telling me my reasoning is wrong I don't doubt it.  Try  
what I just committed - 'default_msg_charset' is now a pref with a  
drop-down list of character sets.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]