[dev] [cvs] commit: incubator/beatnik editrec.php incubator/beatnik/lib Beatnik.php base.php incubator/beatnik/lib/Driver ldap2dns.php sql.php incubator/beatnik/lib/Form Forms.php incubator/beatnik/templates/edit edit.inc incubator/beatnik/templates/listzones ...

[Ben Klang]

On Aug 5, 2006, at 9:47 AM, Duck wrote:

> duck        2006-08-05 06:47:50 PDT
>
>   Modified files:
>     beatnik              editrec.php
>     beatnik/lib          Beatnik.php base.php
>     beatnik/lib/Driver   ldap2dns.php sql.php
>     beatnik/lib/Form     Forms.php
>     beatnik/templates/edit edit.inc
>     beatnik/templates/listzones header.inc row.inc
>     beatnik/templates/view record.inc
>   Log:
>   Basic support of writing records
>
Duck,

What do you mean by "Basic support of writing records" ?  Write  
support was already working?  Oh I see you mean it for the SQL driver.

This commit is many lines of code to be changed with such a brief  
comment.  For instance it appears you corrected line wrap issues  
(possibly a translation problem?  I don't know) in ldap2dns.php but  
the commit note does not mention that.  Regardless that has nothing  
to do with write support.  You appear to move the tracking of  
$curdomain into the session.  This is a fine change but is  
significant enough that it warrants a note in the commit log at least.

Also, why did you remove the link to delete a record?  If you're  
going to do so you need to replace it somehow.

/BAK/

>   Revision  Changes    Path
>   1.10      +7 -6      incubator/beatnik/editrec.php
>   1.16      +2 -2      incubator/beatnik/lib/Beatnik.php
>   1.8       +5 -9      incubator/beatnik/lib/Driver/ldap2dns.php
>   1.7       +28 -3     incubator/beatnik/lib/Driver/sql.php
>   1.2       +4 -6      incubator/beatnik/lib/Form/Forms.php
>   1.14      +5 -1      incubator/beatnik/lib/base.php
>   1.3       +1 -17     incubator/beatnik/templates/edit/edit.inc
>   1.6       +1 -2      incubator/beatnik/templates/listzones/ 
> header.inc
>   1.4       +0 -1      incubator/beatnik/templates/listzones/row.inc
>   1.3       +1 -0      incubator/beatnik/templates/view/record.inc
>
>   Chora Links:
>   http://cvs.horde.org/diff.php/incubator/beatnik/editrec.php? 
> r1=1.9&r2=1.10&ty=u
>   http://cvs.horde.org/diff.php/incubator/beatnik/lib/Beatnik.php? 
> r1=1.15&r2=1.16&ty=u
>   http://cvs.horde.org/diff.php/incubator/beatnik/lib/Driver/ 
> ldap2dns.php?r1=1.7&r2=1.8&ty=u
>   http://cvs.horde.org/diff.php/incubator/beatnik/lib/Driver/ 
> sql.php?r1=1.6&r2=1.7&ty=u
>   http://cvs.horde.org/diff.php/incubator/beatnik/lib/Form/ 
> Forms.php?r1=1.1&r2=1.2&ty=u
>   http://cvs.horde.org/diff.php/incubator/beatnik/lib/base.php? 
> r1=1.13&r2=1.14&ty=u
>   http://cvs.horde.org/diff.php/incubator/beatnik/templates/edit/ 
> edit.inc?r1=1.2&r2=1.3&ty=u
>   http://cvs.horde.org/diff.php/incubator/beatnik/templates/ 
> listzones/header.inc?r1=1.5&r2=1.6&ty=u
>   http://cvs.horde.org/diff.php/incubator/beatnik/templates/ 
> listzones/row.inc?r1=1.3&r2=1.4&ty=u
>   http://cvs.horde.org/diff.php/incubator/beatnik/templates/view/ 
> record.inc?r1=1.2&r2=1.3&ty=u
>
> -- 
> To unsubscribe, mail: cvs-unsubscribe at lists.horde.org

-- 
Ben Klang
Alkaloid Networks
ben at alkaloid.net
404.475.4850
http://projects.alkaloid.net