[dev] More Ansel share stuff...

Chuck Hagenbuch chuck at horde.org
Tue Aug 8 12:43:56 PDT 2006


Quoting Michael Rubinsky <mike at theupstairsroom.com>:

> Seeing how eventually we need the share_name for the   
> $this->_datatree->getByAttributes() call in Share.php, I guess it   
> makes sense to leave Ansel::listGalleries() the way it is (expecting  
>  the share_name) since it is already working everywhere but with the  
>  api.  I'll change the api call to treat $parent as a datatree_id  
> and  lookup the share_name from the datatree_id UNLESS $parent ==   
> DATATREE_ROOT - in this case, we can just pass it through.

Sure, but if you want to phase out names in as many places as  
possible, encapsulating that conversion in the listGalleries method  
sounds like a good thing.

> How does this sound?  A quick look with grep only shows the   
> images/listGalleries method being called with the default values for  
>  $parent so this shouldn't affect any existing code...

Okay with me.

-chuck

-- 
"we are plastered to the windshield of the bus that is time." - Chris


More information about the dev mailing list