[dev] [cvs] commit: ingo/lib/Template Template.php

Chuck Hagenbuch chuck at horde.org
Mon Dec 18 12:21:23 PST 2006


Quoting Michael M Slusarz <slusarz at horde.org>:

> Sounds like reverting is probably the way to go.  Probably also want
> to add Gollem to the list of apps to use the new code since it is
> completely template-ized and, more importantly, its templates (i.e.
> looping templates) are the type that most benefit from the new code.

Okay. I'm working on this now, including Gollem, just in case it helps  
avoid duplicated work.

> I still think we could optimize the reverted template code a bit by
> removing the need for the 'if' parameter.  Just adding every
> scalar/loop statement to the _ifs array shouldn't create that much
> more overhead, especially w/PHP's ref counting.  Then we wouldn't
> have to back out any of the admittedly small number of commits we
> made to horde templates.

Why is it more efficient to check for if tags for every template var?  
I get it with the compiled PHP code, but I'm not sure I understand  
this argument for the parsed templates.

-chuck

--
"we are plastered to the windshield of the bus that is time." - Chris


More information about the dev mailing list