[dev] Some more Agora stuff

[Michael Rubinsky]

While I'm here digging around in Agora, I've come across some other   
things that I'm not quite sure how to fix.

There's an issue with Agora_Messages::hasPermission.  It uses the   
$this reference, but it's called statically by (at least)   
Agora::getMenu() and there is at least one case where I have found   
that causes it to fatal. The problem is if a user navigates to   
hostname/horde/agora directly,  as a guest.  The call in   
Agora::getMenu() to Agora_Messages::hasPermission() passes $scope as   
the second parameter (it should be the third...forum_id should be the   
second).  I was going to fix it, but I'm not familiar enough with   
Agora yet to know what would be a reasonable value here for forum_id?

I've noticed this parameter mis-match in a number of places in the   
code, but again, I'm not always 100% clear where the proper value   
should be coming from.  Basically, just grep'ed for ->hasPermission to  
  find them.


Thanks,
Mike

"Am I getting old, or has the supermarket been playing great music lately?"

-------------- next part --------------
An embedded message was scrubbed...
From: Michael Rubinsky <mike at theupstairsroom.com>
Subject: dev at lists.horde.org
Date: Thu, 21 Dec 2006 00:56:38 -0500
Size: 4151
Url: http://lists.horde.org/archives/dev/attachments/20061220/aefb970d/attachment.mht
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-keys
Size: 2013 bytes
Desc: PGP Public Key
Url : http://lists.horde.org/archives/dev/attachments/20061220/aefb970d/attachment.bin