[dev] [cvs] commit: agora/lib Messages.php api.php

[Michael Rubinsky]

Quoting Chuck Hagenbuch <chuck at horde.org>:

> Quoting Michael Rubinsky <mike at theupstairsroom.com>:
>
>>> Quoting Michael Rubinsky <mike at theupstairsroom.com>:
>>>
>>>> Log:
>>>> References...do these make sense?
>>>>
>>>> Chora Links:
>>>> http://cvs.horde.org/diff.php/agora/lib/Messages.php?r1=1.208&r2=1.209&ty=u
>>>> http://cvs.horde.org/diff.php/agora/lib/api.php?r1=1.78&r2=1.79&ty=u
>>>
>>> Not sure - what's the reason for them?
>>
>> While I was digging around troubleshooting, I saw these and thought
>> it  would be more efficient to pass the refs...and in the back of my
>> mind,  was hoping that it would fix my issue (which it didn't).
>
> With PHP 4, it's sometimes more efficient to pass objects by ref,  
> but it can also be worse. With PHP 5 objects are passed by ref  
> automatically and we're going to need to remove all of these when we  
> move to PHP 5 (violates E_STRICT too). I'd like to see them reverted  
> unless it's in a performance-critical place where testing has shown  
> it helps (which I'm pretty sure this isn't).

Reverted.  Thanks for the clarification regarding refs.


Thanks,
mike

--
The Horde Project (www.horde.org)
mrubinsk at horde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-keys
Size: 2013 bytes
Desc: PGP Public Key
Url : http://lists.horde.org/archives/dev/attachments/20061221/84a1c520/attachment.bin