[dev] OpenId
Chuck Hagenbuch
chuck at horde.org
Mon Apr 16 04:01:08 UTC 2007
Quoting Martin Fraser <mdf at darksnow.net>:
> Thanks for the vote of confidence Chuck, should this be added to the bug
> tracker as a feature request?
That would be fine, but it's not necessary. It's one good way to
collect patches though.
> It was the Jan Rain code I was looking at because it was pear
> installable. I had a look at Wez's code but it looks to me like it is
> only a client side library so to produce a IdP I would need other code
> anyway. So I think I'll use the Jan Rain code I put it in the tests as a
> recommended package, so if the libs are installed it will work.
Okay... from what I know Wez's code is much faster though. So there'd
be advantages to using it where we can. I'd also be fine with OpenID
support requiring PHP 5 if that means we can use things like openssl
streams to speed things up or result in cleaner code.
> I had started doing this as a new module, but the bounty needs it to be
> a part of the core code. So, I'll make a http://domain/horde/idp/
> directory for it. I understand this therefore needs to be a part of the
> horde module itself.
Yup. The /idp part is a required endpoint? Sounds like there'd be a
bit of code there, plus the meat of it either in the Jan Rain libs or
in our own package (fwiw, I'm highly in favor of distributing an
optimized, PHP-focused implementation as a package on pear.horde.org).
> Is there a way to submit this officially or some mechanism I would need
> to go through to do this all officially.
Well, for sharing with others I'd suggest either creating a ticket on
bugs.horde.org or a wiki page on wiki.horde.org for describing the
project and collecting code/patches.
The only thing more official would be to apply for CVS access. I'd
make sure to read horde/docs/CODING_STANDARDS regardless; if this is
something you want to maintain then CVS access might be appropriate,
but for contributing to a core module (instead of a new application)
people generally contribute a set of patches or a chunk of code first.
The OpenID server would certainly qualify once it's committed. :)
> Cheers and I'll let you know when I've got anything at all working.
Looking forward to it!
-chuck
--
"we are plastered to the windshield of the bus that is time." - Chris
More information about the dev
mailing list