[dev] [cvs] commit: turba/lib Turba.php api.php turba/lib/Driver share.php

[Gunnar Wrobel]

"Michael Rubinsky" <mike at theupstairsroom.com> writes:

> mrubinsk    2007-08-16 14:40:14 EDT
>
>   Modified files:
>     lib                  Turba.php api.php 
>     lib/Driver           share.php 
>   Log:
>   When calling removeUserData() for a share enabled source -
>   
>   - Remove the entries from the backend storage
>   - Remove the share from the share system
>   
>   I've tested this and it seems to be ok, but would appreciate someone else trying this out also, since we are nuking data!
>   
>   Revision  Changes    Path
>   1.7       +6 -3      turba/lib/Driver/share.php
>   1.151     +18 -15    turba/lib/Turba.php
>   1.217     +25 -7     turba/lib/api.php
>
>   Chora Links:
>   http://cvs.horde.org/diff.php/turba/lib/Driver/share.php?r1=1.6&r2=1.7&ty=u

The change

-            $sourceName = $this->getName();
+            $sourceName = $this->getContactOwner();

seems strange to me. This gave me a problem with the Kolab driver
since I had warning in there that triggered once the function gets
called with a $sourceName argument other than the current share.

I assumed that deleteAll should only get called after the driver got
instantiated with an existing addressbook. This is at least what
happens when I delete a share at the moment. The code will create a
driver object with and will call deleteAll() on it without arguments
in wich case all the elements in the share the driver is currently
working with are being deleted.

Now the deleteAll call gets the owner of the share delivered as a
default which seems incorrect. The Kolab driver currently just
disregards the value.

Cheers,

Gunnar

-- 
____ http://www.pardus.de _________________ http://gunnarwrobel.de _

E-mail : p at rdus.de                                 Dr. Gunnar Wrobel
Tel.   : +49 40 432 72335                           Bundesstrasse 29
Fax    : +49 40 432 70855                            D-20146 Hamburg
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   >> Mail at ease - Rent a kolab groupware server at p at rdus <<                 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~