[dev] [cvs] commit: framework/Horde/Horde Config.php horde/docs CHANGES framework/VFS/VFS sql.php

[Jan Schneider]

Zitat von Michael M Slusarz <slusarz at horde.org>:

> slusarz     2007-09-28 08:36:52 EDT
>
>   Modified files:
>     Horde/Horde          Config.php
>     docs                 CHANGES
>     VFS/VFS              sql.php
>   Log:
>   SQL VFS driver can now use memcache to cache file data.

This behavior has to be changed somehow.

For one, the configuration says "If memcache is available, use it to  
cache files?", but it tries to do so, even if I don't have Memcache  
enabled in my configuration.

Then, I don't see any reason to use especially Memcache for that  
purpose. If you want to cache the files, use Horde_Cache. People can  
use Memcache for Horde_Cache if they need to.

Next, this is a PEAR library, creating a dependency on a Horde package  
not available through PEAR should be avoided if possible. If not  
possible, this should be done through a general interface, just like  
we allow to pass a logger object to the VFS driver.

Finally, you must not use a global Horde configuration variable, never ever.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/