[dev] [cvs] commit: imp search.php imp/templates/prefs defaultsearchselect.inc imp/docs CHANGES

[Jan Schneider]

Zitat von Michael M Slusarz <slusarz at horde.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>> jan         2007-10-17 19:16:39 EDT
>>
>>   Modified files:
>>     .                    search.php
>>     docs                 CHANGES
>>   Removed files:
>>     templates/prefs      defaultsearchselect.inc
>>   Log:
>>   This always annoyed me: remove default search field preference and
>> show all common fields instead.
>>
>>   Revision  Changes    Path
>>   1.1061    +5 -2      imp/docs/CHANGES
>>   2.189     +2 -10     imp/search.php
>>   1.5       +0 -20
>> imp/templates/prefs/Attic/defaultsearchselect.inc (dead)
>>
>>   Chora Links:
>>   http://cvs.horde.org/diff.php/imp/docs/CHANGES?r1=1.1060&r2=1.1061&ty=u
>>   http://cvs.horde.org/diff.php/imp/search.php?r1=2.188&r2=2.189&ty=u
>
> I disagree.  If you don't like the default search field preference,
> set it to 'NONE' or lock it.

The point is not that I don't like a default search field, but that I  
don't like having only one, having to set it explicitly, and still  
having to reload the whole search page just to add more all-to-common  
search fields.
Since we only include non-empty search fields in the search anyway,  
why not showing the most common fields initially? That will fit 95% of  
all use cases.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/