[dev] [cvs] commit: turba/lib/Driver sql.php

[Michael Rubinsky]

Quoting Matt Selsky <selsky at columbia.edu>:

> On Sun, Oct 28, 2007 at 01:09:08PM -0400, Michael Rubinsky wrote:
>> mrubinsk    2007-10-28 13:09:08 EDT
>>
>>   Modified files:
>>     lib/Driver           sql.php
>>   Log:
>>   Ok, I think this should do it.  Filter date range for birthday  
>> lookups in the DB for the sql driver.
>>   Can someone double check me regarding portability of this across  
>> different RDBMS?  I checked the mans for postres, mySQL, mssql, and  
>> db2 and they all seem to implement this version of substr(), but  
>> I'd appreciate a second set of eyes on this one.
>
> I just tested this on Oracle.  Works fine.

Awesome! Thanks for checking.


>
> Can you change the SQL to use bind variables though?

Done.


Thanks,
mike

--
The Horde Project (www.horde.org)
mrubinsk at horde.org

"Time just hates me. That's why it made me an adult." - Josh Joplin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: PGP Digital Signature
Url : http://lists.horde.org/archives/dev/attachments/20071028/303412f0/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-keys
Size: 2013 bytes
Desc: PGP Public Key
Url : http://lists.horde.org/archives/dev/attachments/20071028/303412f0/attachment-0001.bin