[dev] ansel gallery properties page / gallery permissions

[Michael Rubinsky]

Quoting Chuck Hagenbuch <chuck at horde.org>:

> Quoting Michael Rubinsky <mrubinsk at horde.org>:
>
>> This commit:
>>
>> http://cvs.horde.org/diff.php?r1=1.87&r2=1.88&f=ansel%2Fgallery.php
>>
>> removes various actions from the property page such as permissions
>> editing. I agree this makes sense, but the problem is that with no
>> js,  the gallery action selection does not work.  This means that is
>>  impossible now to edit permissions (the more important of the
>> un-executable actions IMO).
>
> Why not just add a "Go" button inside <noscript> for the gallery
> actions drop-down?

Adding another submit type button can mess with the 'default' action  
when the enter key is pressed.  From what I've read, some browsers  
won't even recognise a default submit if more than one is present, and  
those that do are not necessarily consistent with *which* submit is  
considered default...and I remember from previous discussion with  
you(?) that allowing enter press to submit tags even without js was  
desired.

Plus, although not really the same issue as started this thread, there  
are also the "Delete | Move | Copy" actions with associated select  
list that would need to be dealt with as well and that would require  
yet another 3 submit buttons and the associated code in images.php to  
deal with all the possibilites and confirmation page redirects  
etc...(not that *that's* an excuse but...)

> Also, in general, we've said that Javascript is a reasonable
> requirement for Ansel admins.

Yea, I remember some discussions about this very issue when I first  
started adding the tag functionality...but I didn't think that not  
allowing any users to modify their galleries' permissions, was a Good  
Thing :)

Since some of the actions in that menu wouldn't work without js  
anyway, how about just adding a few links in it's place for non-js  
browsers? I'm thinking upload, download, perms, create subgallery and  
delete gallery, and we would require js for the Delete|Move|Copy  
actions....

...or we could just require js for the whole app :)

Thanks,
mike

--
The Horde Project (www.horde.org)
mrubinsk at horde.org

"Time just hates me. That's why it made me an adult." - Josh Joplin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-keys
Size: 2200 bytes
Desc: PGP Public Key
Url : http://lists.horde.org/archives/dev/attachments/20080203/4ba5aa74/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: PGP Digital Signature
Url : http://lists.horde.org/archives/dev/attachments/20080203/4ba5aa74/attachment-0001.bin