[dev] [cvs] commit: ansel/lib/Block gallery.php random_photo.php

Chuck Hagenbuch chuck at horde.org
Wed Mar 19 17:43:52 UTC 2008


Quoting Michael Rubinsky <mrubinsk at horde.org>:

> We already filter on PERMS_SHOW by default, but currently I guess we  
>  interpret that more as a PERMS_READ - which I assume was done for   
> performance reasons.  Are you suggesting that we have to make at  
> least  one more permission check for each gallery that is being  
> displayed in  this case -   PERMS_SHOW in  
> Ansel_Storage::listGalleries() and another  to  
> Ansel_Gallery::hasPermission() for PERMS_READ when attempting to   
> display the gallery/tile/title/image names in the recent block  
> etc...  (which would include the check for other "extended"  
> permissions?)

I *think* that sounds about right. It's only a check for permissions  
that are already fetched, right? So it shouldn't be a problem in that  
respect.

We might make a decision that for Ansel SHOW does let you see the name  
of the gallery - that feels right to me.

-chuck


More information about the dev mailing list