[dev] [cvs] commit: imp/lib Template.php

[Jan Schneider]

Zitat von Michael M Slusarz <slusarz at horde.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>> jan         2008-08-28 05:09:17 EDT
>>
>>  Modified files:
>>    lib                  Template.php
>>  Log:
>>  Invalidate cache if gettext option changed.
>>
>>  Revision  Changes    Path
>>  1.11      +2 -2      imp/lib/Template.php
>>
>>  Chora Links:
>>  http://cvs.horde.org/diff.php/imp/lib/Template.php?r1=1.10&r2=1.11&ty=u
>
> I think we need some kind of separators between each data entry.   
> With this change:
>
> +        $cacheid = 'horde_template' . filemtime($file) . $file .  
> $this->getOption('gettext');
>          if (!$force && is_null($this->_template) && isset($this->_cache)) {
> -            $cacheid = 'horde_template|' . filemtime($file) . '|' . $file;
>
> there is the (remote) possibility of a collision.  Example:  
> filemtime is 1 second after UNIX epoch (1), filename is  
> "2199422451", and gettext option is true (1).  This collides with a  
> filemtime of "1219942245", filename of "1", and gettext option of  
> true.

Well, that's really a remote possibility, but added the separators  
back anyway.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/