[dev] [commits] Horde branch master updated. 67f61bf5a11305264192782bafdc9bd640af09fb

[Chuck Hagenbuch]

Quoting Jan Schneider <jan at horde.org>:

> Zitat von Chuck Hagenbuch <chuck at horde.org>:
>
>> Quoting Jan Schneider <jan at horde.org>:
>>
>>> -----------------------------------------------------------------------
>>> commit 7cda93861ba418013ae076b3cd6648412d99bfaf
>>> Author: Jan Schneider <jan at horde.org>
>>> Date:   Fri Jan 9 14:54:45 2009 +0100
>>>
>>>   Fix position of preg_replace() call.
>>>   AFAICS this replace could stop the preg_match() further down  
>>> from working.
>>>
>>> framework/Autoloader/lib/Horde/Autoloader.php |    5 +----
>>> 1 files changed, 1 insertions(+), 4 deletions(-)
>>>
>>> http://cvs.horde.org/diff.php/framework/Autoloader/lib/Horde/Autoloader.php?rt=horde-git&r1=9efd36e6fc475e4d11889cd02c9afe826b956f7b&r2=7cda93861ba418013ae076b3cd6648412d99bfaf
>>
>> This will break anything where $replace is null, though. This  
>> worked fine for me before - do you have a test case that failed?
>
> No, why? There has been another !is_null() check in the old version too.

The old one did the preg_replace if $replace wasn't null; now it's  
done if $replace isn't null OR if the preg_match succeeds.

-chuck