[dev] [cvs] commit: framework/Horde/Horde Exception.php

Michael M Slusarz slusarz at horde.org
Sun Feb 22 19:55:16 UTC 2009


Quoting Jan Schneider <jan at horde.org>:

> Zitat von Michael M Slusarz <slusarz at horde.org>:
>
>> slusarz     2009-02-21 23:07:58 EST
>>
>>  Modified files:
>>    Horde/Horde          Exception.php
>>  Log:
>>  Even better: allow other Exceptions to be passed in also.
>>
>>  Revision  Changes    Path
>>  1.5       +3 -3      framework/Horde/Horde/Exception.php
>
> is_object() is a bit too broad, why not checking for getMessage() and
> getCode() methods in the object? I think we already do this somewhere
> else (Horde::logMessage, Horde::fatal, Notification::notify).

Agreed - I was a bit lazy in checking.  Cleaned up in CVS.

michael

-- 
___________________________________
Michael Slusarz [slusarz at horde.org]



More information about the dev mailing list