[dev] [cvs] commit: framework/Notification Notification.php

Michael M Slusarz slusarz at horde.org
Mon Feb 23 18:49:47 UTC 2009


Quoting Jan Schneider <jan at horde.org>:

> Zitat von Michael M Slusarz <slusarz at horde.org>:
>
>> slusarz     2009-02-22 22:40:36 EST
>>
>>  Modified files:
>>    Notification         Notification.php
>>  Log:
>>  Get code info from PEAR_Error object, if necessary.
>>
>>  Revision  Changes    Path
>>  1.71      +6 -3      framework/Notification/Notification.php
>
> I'm not sure if this is a good idea, since the code doesn't have to be
> a valid notification class, e.g. if a PEAR_Error bubbles from an
> external PEAR package.

Doesn't Notification ignore a class it doesn't recognize?

The main advantage is to reduce this annoying statement:
$notification->push($e, $e->getCode());

to this:
$notification->push($e);

michael

-- 
___________________________________
Michael Slusarz [slusarz at horde.org]



More information about the dev mailing list