[dev] [commits] Horde branch master updated.

[Michael M Slusarz]

Quoting Chuck Hagenbuch <chuck at horde.org>:

> Quoting Michael M Slusarz <slusarz at horde.org>:
>
>> The branch "master" has been updated.
>> The following is a summary of the commits.
>>
>> from: 9a984163d1813dcb27454914939e713b1e7dee9e
>>
>> 2c018fb... Import Horde_Cipher:: from CVS.
>> 909134e... Horde_Cipher_Blowfish is broken.  Fallback to RC2 instead.
>>
>> -----------------------------------------------------------------------
>>
>> commit 2c018fb41a8d8b9b39d14260ff2aeeb7cf091548
>> Author: Michael M Slusarz <slusarz at curecanti.org>
>> Date:   Sun Jul 5 14:29:25 2009 -0600
>>
>>    Import Horde_Cipher:: from CVS.
>>
>>    Am dubious about the state of this package, especially since neither
>>    blowfish nor Cast128 pass the unit tests (they don't work in CVS either
>>    going back for many years).  It might be best to dump them or else use
>>    PEAR's Crypt_Blowfish module instead.
>
> Sounds like it shouldn't be in H4 then...

We still need some sort of hashing fallback (Horde_Secret:: uses it if  
mcrypt is not available).  So keeping Horde_Cipher (namely the Rc2  
and/or Des parts) may be useful to prevent the need for an optional  
PEAR module if the optional mcrypt is not available.

michael

-- 
___________________________________
Michael Slusarz [slusarz at horde.org]