[dev] [commits] Horde branch master updated. 89ba60ebd8227e84abe696131778097c4770d99d

[Michael M Slusarz]

Quoting Jan Schneider <jan at horde.org>:

> Zitat von Chuck Hagenbuch <chuck at horde.org>:
>
>> Quoting Jan Schneider <jan at horde.org>:
>>
>>>   How do we want to deal with optional configuration files?
>>>   We used to ignore PEAR_Errors where config files are optional.  
>>> This no longer
>>>   works with exceptions.
>>>
>>> framework/Core/lib/Horde.php |    3 ++-
>>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>>
>>> http://git.horde.org/diff.php/framework/Core/lib/Horde.php?rt=horde-git&r1=7aa6dfd229b7ea0086c230781b28663be81d112a&r2=6c1cfaf412b80ecf29fea8c589618480f33dadec
>>
>> I think we should have default configs for everything, and  
>> automatically include local overrides. We need to have a base level  
>> of configuration done, but in terms of optional vs. required files  
>> I don't think there should be any base configs missing in the  
>> default install (instead of foo.php.dist and foo.php, we should  
>> ship foo.php and automatically look for foo_local.php).
>
> That doesn't make sense to me, what's the purpose of two  
> configuration files? Either configuration through foo.php is  
> required, then we should still distribute foo.php.dist. Or we assume  
> defaults for everything and consider the configuration foo.php as an  
> override, if it exists.
>
> Only the latter is actually a solution for the problem I mentioned  
> in the commit, because in this case, configuration files are no  
> longer required at all. If we still require some configuration  
> files, the problem of distinguishing between required and optional  
> files still isn't solved.

I agree with Jan.  We would be going from 1 config file to 2 config  
files.  I fail to see how that makes things less complicated.

And to make it possible for people to quickly understand what config  
values can be changed, we necessarily need to list all of this config  
information somewhere.  So it still makes more sense to me to do this  
in a config file environment rather than anything else (we must  
certainly should *not* be enforcing default values within the actual  
code.  that makes no sense).

michael

-- 
___________________________________
Michael Slusarz [slusarz at horde.org]