[dev] [commits] Horde branch master updated. d3a3a8ba4f403b2c05c0573ca519b7e349a8c657

Chuck Hagenbuch chuck at horde.org
Wed Jul 15 03:27:56 UTC 2009


Quoting Chuck Hagenbuch <chuck at horde.org>:

>> I don't think it's good practice to use exceptions for anything but  
>> throwing. Beside that, wrapping in a class when we need the  
>> different parts (message, file, line) later anyway, is unnecessary  
>> IMO.
>
> I agree. Also, if the goal is to get rid of __FILE__ and __LINE__ (a  
> good goal), we can just use debug_backtrace() to get that.

One step further - Horde::fatal() shouldn't be necessary at all. It  
should be replaced by the last-ditch global exception handler I  
mentioned earlier - any uncaught exception ends up triggering a fatal  
anyway. They should be the same thing.

-chuck


More information about the dev mailing list