[dev] [commits] Horde-Hatchery branch master updated. 32b8d7d18cb8987b1235005df6567d4d37e87950

[Jan Schneider]

Zitat von Michael M Slusarz <slusarz at horde.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>>> commit 7acd3c79d290bfcbe93471b952d0009411277490
>>> Author: Michael M Slusarz <slusarz at curecanti.org>
>>> Date:   Wed Jul 29 12:59:10 2009 -0600
>>>
>>>   Add upgrade system task
>>>
>>> imp/lib/IMP.php                           |    6 ----
>>> imp/lib/LoginTasks/SystemTask/Upgrade.php |   37  
>>> +++++++++++++++++++++++++++++
>>> 2 files changed, 37 insertions(+), 6 deletions(-)
>>> create mode 100644 imp/lib/LoginTasks/SystemTask/Upgrade.php
>>
>> Shouldn't we better include a version number or date with the class  
>> name? IIUC this will only be run once ever, right? That means that  
>> we can't use it for any future upgrade tasks.
>
> Good point - I thought about this but for some reason didn't do it.   
> But your analysis is correct.  This should be renamed to  
> UpgradeFromImp4.php.

I'm afraid this even has to be more fine grained for users (like us  
developers), running Horde from git. It's like all the date-signed  
upgrade scripts in scripts/upgrade of HEAD/master and the stable  
version-signed upgrade scripts in the stable branch.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digitale PGP-Unterschrift
URL: <http://lists.horde.org/archives/dev/attachments/20090730/000fb66d/attachment.bin>