[dev] [commits] Horde branch master updated. d0396d8d495ed66fa088ae490a1d0ff3dbe16de9

[Jan Schneider]

Zitat von Chuck Hagenbuch <chuck at horde.org>:

> Quoting Chuck Hagenbuch <chuck at horde.org>:
>
>> Quoting Jan Schneider <jan at horde.org>:
>>
>>> The branch "master" has been updated.
>>> The following is a summary of the commits.
>>>
>>> from: 838f1035739dc2440aba541bb452f02184d7f76c
>>>
>>> d0396d8... Implement Countable.
>>>
>>> -----------------------------------------------------------------------
>>>
>>> commit d0396d8d495ed66fa088ae490a1d0ff3dbe16de9
>>> Author: Jan Schneider <jan at horde.org>
>>> Date:   Fri Aug 28 23:08:31 2009 +0200
>>>
>>>   Implement Countable.
>>>
>>> framework/Db/lib/Horde/Db/Adapter/Abstract.php |   12 +++++++++++-
>>> 1 files changed, 11 insertions(+), 1 deletions(-)
>>>
>>> http://git.horde.org/patchsets.php/?rt=horde-git&ps=d0396d8d495ed66fa088ae490a1d0ff3dbe16de9
>>
>> This doesn't make sense to me - what does it mean for a database  
>> adapter to have a count?

See the method doc for what it means. And it was a prerequisite to  
make count work in Horde_Rdo_List.

> Also, from the PDO docs:
>
> If the last SQL statement executed by the associated PDOStatement  
> was a SELECT statement, some databases may return the number of rows  
> returned by that statement. However, this behaviour is not  
> guaranteed for all databases and should not be relied on for  
> portable applications.
>
> I'm going to revert this. We should be getting the info a different  
> way for SELECTs, and it's already available for update and delete  
> statements.

Well, we were already tracking this information in Horde_Db, so I  
assumed it would be safe to use it.
OTOH I just discovered some inconsistencies on a different system, but  
I didn't track it down completely yet.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/