[dev] [commits] Horde-Hatchery branch master updated. 9b29f5c7fd7573cfda3bb369801a1e156d0a9643

[Michael Rubinsky]

Quoting Jan Schneider <jan at horde.org>:

> The branch "master" has been updated.
> The following is a summary of the commits.
>
> from: 2ef2068c1c895c7f645ac12c1873a1659f62732e
>
> 021991b... Revert "fix reveresed logic for determining if  
> notifications are shown"
> 7d228df... Move most of quickAdd() to Kronolith:: so that we can  
> call it directly.
> 2a8d848... We always are in the ajax interface (for now).
> 9b29f5c... Fix driver loading.
>
> -----------------------------------------------------------------------
>
> commit 021991b486775b597553a15f4cc929672f8e7b7f
> Author: Jan Schneider <jan at horde.org>
> Date:   Mon Aug 31 16:21:41 2009 +0200
>
>     Revert "fix reveresed logic for determining if notifications are shown"
>
>     This reverts commit 9e3d56deae198b7904a52df03252a7e97366d1b3.
>
>     Not sure what this was supposed to do, but it broke  
> notifications in the ajax interface.
>
>  kronolith/lib/Notification/Listener/Status.php |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> http://git.horde.org/patchsets.php/?rt=horde-hatchery&ps=021991b486775b597553a15f4cc929672f8e7b7f

Without the change, notifications that are pushed in kronolith's  
non-ajax interface will also have the 'store' option set, so the  
notifications will not be pushed to the page.  I made these changes  
while trying to figure out why notifications were not showing when  
saving a new event the triggered an notification email being sent to  
attendees. For example, create a new event in the non-ajax interface,  
add some attendees, check the 'Send updates to all attendees?' check  
box and save. No notification will be sent. If you un-revert the  
change the notification will show. I think we need a check there to  
see if we are in dynamic mode or traditional mode before setting the  
store option...

Thanks,
mike

--
The Horde Project (www.horde.org)
mrubinsk at horde.org

"Time just hates me. That's why it made me an adult." - Josh Joplin