[dev] [commits] Horde-Hatchery branch master updated. 96969d40005c102da956e8f83c0d009aee68d6b1

[Jan Schneider]

Zitat von Chuck Hagenbuch <chuck at horde.org>:

>
> Quoting Chuck Hagenbuch <chuck at horde.org>:
>
>> The branch "master" has been updated.
>> The following is a summary of the commits.
>>
>> from: c480d44f2a892e5fda216a1c560e6e11ec11c6e0
>>
>> 96969d4... Revert "Return the new primary id if creating objects.  
>> We should really manipulate the existing Rdo_Base object, if one is  
>> passed."
>
> I agree, but I thought we already did that:
>
>             if (!$id) {
>                 // Object doesn't exist yet; create it instead.
>                 $object = $this->create($fields);
>                 return 1;
>             }

How would that change the Rdo_Base object? We're assigning $object a  
new object, dereferencing it this way.

> If that doesn't work, then we should fix that. I think the other  
> method semantics were correct as-is.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/