[dev] [commits] Horde-Hatchery branch master updated. 1a57ad3e16e1a3e92b0f087ba1765c9089c48577

Chuck Hagenbuch chuck at horde.org
Sun Sep 27 16:31:48 UTC 2009


Quoting Jan Schneider <jan at horde.org>:

> Zitat von Michael M Slusarz <slusarz at horde.org>:
>
>> The branch "master" has been updated.
>> The following is a summary of the commits.
>>
>> from: 94553bd518124a2f1d9347f618077e313b1dcb5c
>>
>> d90ce60... Fix adding phishing status info
>> 5229eff... This style has been moved inside the HTML viewer.
>> 1a57ad3... Correctly show phishing highlighting when viewing inline
>
> We should rather move HTML/CSS code *out* of the PHP libraries,  
> rather than adding more. I understand the rationale, but this is  
> really not the direction we should take.

I strongly agree, though I think there is probably a place for  
packages to come with some default views (which could be overridden of  
course). That way we get HTML out of the classes, but we can still  
bundle re-useable UI bits. I'm happy to help move these things to View  
partials.

-chuck


More information about the dev mailing list