[dev] WebDAV package v0.1

[Jan Schneider]

Zitat von Evert Pot <evertpot at gmail.com>:

> On 2009-10-19, at 3:35 PM, Jan Schneider wrote:
>
>> Hi Evert,
>>
>> Zitat von Evert Pot <evertpot at gmail.com>:
>>
>>> Here's the package for horde-git:
>>
>> Two packaging related issues:
>> - When installing the tarball with pear, I get a: ERROR: file  
>> /tmp/pear/download/DAV/DAV-0.0.1/lib/Horde/DAV/ApplicationCollection.php  
>> does not exist. Funnily, it's the ApplicationFile.php script  
>> though, that's not correctly linked in the <phprelease> section of  
>> package.xml
>
> Not sure how that happened, but this should be an easy fix.
>
>> - Since this is the Horde wrapper of the Sabre_DAV package, you  
>> should rather make it a patch against the framework/Sabre library  
>> that already exists in the horde-git repository.
>
> I figured a the Horde_Dav package would be more appropriate than  
> 'Sabre_DAV', hence the rename. I can supply this as a real patch  
> though (just need to figure out git a bit more).

That's fine for me too. As I mentioned earlier, I'm not set on  
Horde_Dav vs. Sabre_Dav anyway.

>> To the code:
>> - There are a few coding style issues, but that's not important for  
>> now. The only thing that you should change is camel-case'ing the  
>> class names, so that it's easier to patch the code right from the  
>> start, when it's integrated into Horde. I.e. Horde_Dav, not  
>> Horde_DAV.
>
> No problem making it Dav. Is there a specific standards guide I can  
> follow, or do you guys use the Pear 1 coding standards?

http://cvs.horde.org/co.php/horde/docs/CODING_STANDARDS

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/