[dev] [commits] Horde branch master updated. 653bcd843b6af4fefe781d3a562fe628111f6e56

Chuck Hagenbuch chuck at horde.org
Sat Dec 5 03:32:09 UTC 2009


Quoting Jan Schneider <jan at horde.org>:

> commit 97d2e7e849a21f50578932050f7d390366d3005f
> Author: Jan Schneider <jan at horde.org>
> Date:   Thu Dec 3 17:43:59 2009 +0100
>
>     E_STRICT fixes.
>
>  framework/Date/lib/Horde/Date.php                 |    6 +++---
>  framework/Date/lib/Horde/Date/Repeater.php        |    2 +-
>  framework/Date/test/Horde/Date/DateTest.php       |   12 +++++++-----
>  framework/Date/test/Horde/Date/RecurrenceTest.php |    1 +
>  4 files changed, 12 insertions(+), 9 deletions(-)
>
> http://git.horde.org/diff.php/framework/Date/lib/Horde/Date.php?rt=horde-git&r1=8aada892bc165f140ced8ec9fb41bd5cb071ee91&r2=97d2e7e849a21f50578932050f7d390366d3005f
> http://git.horde.org/diff.php/framework/Date/lib/Horde/Date/Repeater.php?rt=horde-git&r1=f3baae109f1449d30e0061e3861ceb3e0feb1a90&r2=97d2e7e849a21f50578932050f7d390366d3005f
> http://git.horde.org/diff.php/framework/Date/test/Horde/Date/DateTest.php?rt=horde-git&r1=d7f2ecb0e5c8e73596ca6b660409532f5d734621&r2=97d2e7e849a21f50578932050f7d390366d3005f
> http://git.horde.org/diff.php/framework/Date/test/Horde/Date/RecurrenceTest.php?rt=horde-git&r1=d49713e59ef1ad63dc457419e954465a832eb91c&r2=97d2e7e849a21f50578932050f7d390366d3005f


In these tests, the original idea of not calling  
date_default_timezone_set() when the file was included was to avoid  
side effects of the test. You added two calls at the top level, but  
maintained that in a few others places. Not sure what the logic is  
there?

-chuck


More information about the dev mailing list