[dev] [commits] Horde branch master updated. 536d790bfe82153b9075661a2e53d45b21bd8b8b

Michael M Slusarz slusarz at horde.org
Tue Dec 8 02:13:29 UTC 2009


Quoting Jan Schneider <jan at horde.org>:

> commit 536d790bfe82153b9075661a2e53d45b21bd8b8b
> Author: Jan Schneider <jan at horde.org>
> Date:   Tue Dec 8 01:40:56 2009 +0100
>
>     Add explicit toString() method that accepts a $raw parameter to  
> override, but
>     not overwrite the local $raw property.
>     Michael, can we remove setRaw() with this new feature?
>
>  framework/Url/lib/Horde/Url.php |   20 +++++++++++++++++---
>  1 files changed, 17 insertions(+), 3 deletions(-)
>
> http://git.horde.org/diff.php/framework/Url/lib/Horde/Url.php?rt=horde-git&r1=2d8e77cca5e4dcf99a7012198165d0239af6e3c8&r2=536d790bfe82153b9075661a2e53d45b21bd8b8b

I don't think so.  You can get a Horde_Url object from a function  
return, so you don't have access to setting $raw via the constructor.   
But you also may not yet want to cast to a string.  For example:

$a = Horde::applicationUrl('foo.php')->setRaw(true)->add('bar', 1);

This is handy because it creates the necessary URL data, but it leaves  
open the possibility that further processing can be done on $a.  I  
really don't think we need to be calling toString() functions  
explicitly either.

Any reason why setRaw() isn't desired?

michael

-- 
___________________________________
Michael Slusarz [slusarz at horde.org]



More information about the dev mailing list