[dev] [commits] Horde branch master updated. 56c3d7925d59651bd9f040d9151aeb8d40b3872c

[Michael M Slusarz]

Quoting Jan Schneider <jan at horde.org>:

> Zitat von Michael M Slusarz <slusarz at horde.org>:
>
>> commit 56c3d7925d59651bd9f040d9151aeb8d40b3872c
>> Author: Michael M Slusarz <slusarz at curecanti.org>
>> Date:   Fri Jan 8 14:01:14 2010 -0700
>>
>>    Horde::selfUrl() cleanups
>>
>> framework/Core/lib/Horde.php |    2 +-
>> imp/attachment.php           |    2 --
>> imp/compose.php              |    5 ++---
>> imp/lib/Contents.php         |    3 +--
>> imp/lib/IMP.php              |    4 ++--
>> imp/message.php              |    3 +--
>> imp/thread.php               |    6 ++----
>> 7 files changed, 9 insertions(+), 16 deletions(-)
>>
>> http://git.horde.org/diff.php/framework/Core/lib/Horde.php?rt=horde-git&r1=674073b5951b1cdba9c274ecac976df94c7c7779&r2=56c3d7925d59651bd9f040d9151aeb8d40b3872c
>> http://git.horde.org/diff.php/imp/attachment.php?rt=horde-git&r1=99e7aaf59cae56bbdbbfe3256ce8d4564f547e49&r2=56c3d7925d59651bd9f040d9151aeb8d40b3872c
>> http://git.horde.org/diff.php/imp/compose.php?rt=horde-git&r1=99e7aaf59cae56bbdbbfe3256ce8d4564f547e49&r2=56c3d7925d59651bd9f040d9151aeb8d40b3872c
>> http://git.horde.org/diff.php/imp/lib/Contents.php?rt=horde-git&r1=0e2ddda553269d4883ef908b4b42488ec8940a8b&r2=56c3d7925d59651bd9f040d9151aeb8d40b3872c
>> http://git.horde.org/diff.php/imp/lib/IMP.php?rt=horde-git&r1=727dbedf976187d37ac36a524c58a77cd13f3d0f&r2=56c3d7925d59651bd9f040d9151aeb8d40b3872c
>> http://git.horde.org/diff.php/imp/message.php?rt=horde-git&r1=ffe807f0b7865b8e9224b9faf01743ee79f7e12f&r2=56c3d7925d59651bd9f040d9151aeb8d40b3872c
>> http://git.horde.org/diff.php/imp/thread.php?rt=horde-git&r1=e6785ab91a4635bb9c46b980f72b5c1840de3c74&r2=56c3d7925d59651bd9f040d9151aeb8d40b3872c
>
> You can even leave out the ->remove(array('actionID')) call, because  
> ->add(array('actionID' => 'foo')) overwrites existing actionID  
> parameters.

Do we want that behavior?  How can you add multiple values to a single  
parameter name using multiple add calls?  I see there is code in add()  
to treat parameter keys with '[]' at the end as containing multiple  
values, but I'm not sure that is the proper solution since any  
parameter key can contain multiple values (the '[]' part is  
PHP-specific; there is no requirement that the URL's generated from  
Horde_Url are going to point to a PHP script though).

michael

-- 
___________________________________
Michael Slusarz [slusarz at horde.org]