[dev] Show attachment icon on messages without attachments

[Jan Schneider]

Zitat von Michael M Slusarz <slusarz at horde.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>> Zitat von Michael M Slusarz <slusarz at horde.org>:
>>
>>> I have struggled off and on for awhile with myself whether to  
>>> remove this flag entirely.  After thinking about it a bit more, I  
>>> am seriously considering removing it.
>>
>> How about another compromise and showing it only for multipart  
>> messages that are not multipart/alternative in the base mime part?
>
> I thought about it, but this is not 100% foolproof either.   
> multipart/alternative parts may contain all parts that can't be  
> viewed inline, which (from an intuitive standpoint) makes that  
> message contain an attachment.

Yes, sure, this can't be a 100% solution unless we parse the complete  
message. But I think this would still be a good compromise between  
best guess and least performance drawback.

> I think the best compromise, especially since if I take this out we  
> will be getting complaints for the next 5 years, is to re-add  
> attachment flagging to the msglist_flags hook.

I don't have a strong opinion about this. I'm sure 99.9% of the user  
will use the hook example as-is. But I can see how we can delegate  
reponsibility for a 100% accurate attachment detection to the  
more-demanding users by using a hook.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/