[dev] [commits] Horde branch master updated. 741c82203aa3eac200faa1e5c068c3edd4b69232

[Jan Schneider]

Zitat von Chuck Hagenbuch <chuck at horde.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>> commit 7e0d11f0689e7c0ffea261acb261580a7f9cf3c6
>> Author: Jan Schneider <jan at horde.org>
>> Date:   Thu May 6 11:48:59 2010 +0200
>>
>>    Don't require a logger in Horde_Db_Migrator.
>>
>> framework/Alarm/test/Horde/Alarm/SqlTest.php     |    3 +-
>> framework/Db/lib/Horde/Db/Migration/Migrator.php |   25  
>> ++++++++++++---------
>> 2 files changed, 15 insertions(+), 13 deletions(-)
>>
>> http://git.horde.org/diff.php/framework/Alarm/test/Horde/Alarm/SqlTest.php?rt=horde-git&r1=577dffbdae82bb111245db2407d85440a2408a3c&r2=7e0d11f0689e7c0ffea261acb261580a7f9cf3c6
>> http://git.horde.org/diff.php/framework/Db/lib/Horde/Db/Migration/Migrator.php?rt=horde-git&r1=236b104d6c6c14b5e32151b1e024961ab1669e66&r2=7e0d11f0689e7c0ffea261acb261580a7f9cf3c6
>
> Why not? Especially with the injector it's trivial to supply a null  
> logger if you don't want the messages going anywhere.

That's the case for Horde_Support_Stub too. I've chosen this one over  
a null logger, because:
- it doesn't add another dependency to the tests, resp. doesn't pull  
another package's code into the tested code.
- Horde_Support_Stub is a really elegant solution for this job.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/