[dev] [commits] Horde branch master updated. a96642d3db2e2910d3ad0c3d6224e4d214a4c224

[Ben Klang]

On May 18, 2010, at 6:54 PM, Michael Rubinsky wrote:

> 
> Quoting Ben Klang <ben at alkaloid.net>:
> 
>> On May 4, 2010, at 11:20 AM, Michael Rubinsky wrote:
>> 
>>> 
>>> Quoting Ben Klang <ben at alkaloid.net>:
>>> 
>>>> The branch "master" has been updated.
>>>> The following is a summary of the commits.
>>>> 
>>>> from: d463b9f4bf2dfc4c0700eec2f133345bf2f1b838
>>>> 
>>>> cf9dedd Jonah: Util::bufferOutput() -> Horde::startBuffer()
>>>> c4da0db Jonah: Use injector to get Perms instance
>>>> a96642d Jonah: Two more Horde_Themes conversions
>>> 
>>>> commit a96642d3db2e2910d3ad0c3d6224e4d214a4c224
>>>> Author: Ben Klang <ben at alkaloid.net>
>>>> Date:   Tue May 4 10:35:55 2010 -0400
>>>> 
>>>>   Jonah: Two more Horde_Themes conversions
>>>> 
>>>> jonah/lib/Block/tree_menu.php     |    2 +-
>>>> jonah/templates/common-header.inc |    4 ++--
>>>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>>> 
>>>> http://git.horde.org/diff.php/jonah/lib/Block/tree_menu.php?rt=horde-git&r1=52fe3b1a1a50a851a9c23d2499cf4b8e65df1c76&r2=a96642d3db2e2910d3ad0c3d6224e4d214a4c224
>>>> http://git.horde.org/diff.php/jonah/templates/common-header.inc?rt=horde-git&r1=d80e67854208b7bc13b1002103a7104c4d83c7c5&r2=a96642d3db2e2910d3ad0c3d6224e4d214a4c224
>>> 
>>> You should be using Horde::img() (which, in turn will use Horde_Themes::img() to get the image URI) in places where you want to output an img tag for the image. Horde_Themes::img() only returns an object with the URI for the image...
>>> 
>> 
>> In both of these places I specifically do not want an <img> tag.  The Horde_Themes::img() feels a little ugly here (especially vs. what we did in Horde 3), but it was the only option I saw.  Any other suggestions?
> 
> Sorry, I wasn't talking about these two commits specifically, I noticed it on the initial import commit, so there were no diffs to link to... There are a number of places were you used Horde_Themes::img() in places where you *do* want an image tag...like in jonah/stories/index.php for example.
> 
> --

Oh, alright.  I'll take a look through the app and see if I can clean it up a bit.

/BAK/

-- 
Ben Klang
Alkaloid Networks LLC
ben at alkaloid.net
404.475.4850
http://projects.alkaloid.net