[dev] [commits] Horde branch master updated. 104e3198ce8b82e1a469dce43420d2d6fa7e2a7d

[Michael M Slusarz]

Quoting Chuck Hagenbuch <chuck at horde.org>:

> Quoting Michael M Slusarz <slusarz at horde.org>:
>
>>>>  Rename Horde_Db_Adapter_Base to Horde_Db_Base and change to a shortcut
>>>>  to return the base Horde DB object.
>
> This sounds like something that belongs in Core, not in the Horde_Db  
> package. I need to review a bunch of these commits still, but a lot  
> of stuff creeping into the Db package looks wrong to me.

This is in Core - I renamed the binder.  Nothing in this commit  
changed anything in Horde_Db.

I still have concerns over this type of binder usage, however (an  
example I found in content/):

public function __construct(Horde_Db_Adapter_Base $db, ...)

This usage assumes that a horde installation uses a single database.   
That is an incorrect assumption though.

michael

-- 
___________________________________
Michael Slusarz [slusarz at horde.org]